Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/kubernetes connector refactor #462

Merged
merged 26 commits into from
Oct 5, 2022

Conversation

linkous8
Copy link
Contributor

No description provided.

dependant on kubernetes connector, fix misc type hints, fix conftest
errors
scrape failures outside scope of tested code
- further harden against minikube failed start
- remove lingering rollout references
- update unfinished checks of kubenernetes connector
applying remedies, disable redundant test_checks_timeout_with_halt
tmp_path, fix lingering reference to opsani_dev checks
controller_type_name, delete placeholder checks class used during
refactor
for container ports instead of None
Copy link
Contributor

@DanielHHowell DanielHHowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just two very minor items/suggestions. However, I'm not understanding the cause of the failing system test at first glance

@linkous8 linkous8 merged commit af53d05 into main Oct 5, 2022
@linkous8 linkous8 deleted the feature/kubernetes-connector-refactor branch October 5, 2022 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants